Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nette/Caching has its own interface for bulk reading #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kaczmi
Copy link

@Kaczmi Kaczmi commented Jun 3, 2022

Bulk reading in this moment is not working, because default implementation \Nette\Caching\Cache is hashing keys using this method: https://github.com/nette/caching/blob/master/src/Caching/Cache.php#L337

When I try to execute bulk read in application, this transformation is not triggered and records are not found, although they are there. Now I can execute \Nette\Caching\Cache::bulkLoad() and everything works just fine.

IMultiReadStorage interface could be removed, but not sure about possible BC breaks.

@Kaczmi Kaczmi marked this pull request as ready for review June 3, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant